Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

@itoys
Copy link
Contributor

@itoys itoys commented Feb 28, 2018

Includes back compatibility for old RN versions
Resolves #1214

@itoys itoys merged commit be3633a into master Mar 12, 2018
@itoys itoys deleted the feature/aapt2-gradle branch March 12, 2018 15:14
CFKevinRef referenced this pull request in facebook/react-native Jul 28, 2018
@rexih
Copy link

rexih commented Aug 5, 2019

i'm an android developer, our team need to use code push and i'm studying the codepush.gradle file,
i check the commit said

  • AAPT2-compatible Android build process integration
  • enhancement
  • enhancement
  • fix assembleDebug

it was ambiguous for me,
could you tell me the difference of the two conditional branch :
if (variant.hasProperty("bundleJsAndAssets")) { } else { }
i found if has the property ,only create generateBundledResourcesHash task, if not ,it will create generateBundledResourcesHash and recordFilesBeforeBundleCommand task

why there were two different behavor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requiring images with latest gradle fails release builds

3 participants